fix(iceberg): fix commit_checkpoint_interval for iceberg table with connector #19788
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
reviewed
Dec 12, 2024
Because I want to make it available in every source connector when creating a table with an iceberg engine, making it a known field will be invasive to every connector property, while it also doesn't make sense to make it a known field when the table is hummock table. |
StrikeW
approved these changes
Dec 13, 2024
| // remove commit_checkpoint_interval from source options, otherwise it will be considered as an unknown field. | ||
| source | ||
| .as_mut() | ||
| .map(|x| x.with_properties.remove(COMMIT_CHECKPOINT_INTERVAL)); |
There was a problem hiding this comment.
I guess it will be persisted in the sink plan, so even remove it from the PbSource, it can still recovery correctly?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…terval_with_connector
chenzl25
deleted the
dylan/fix_iceberg_table_commit_checkpoint_interval_with_connector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
commit_checkpoint_intervalfrom the connector property which will result in a unknown field.Checklist
Documentation
Release note