Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for dml_rate_limit #19679

Merged
merged 8 commits into from
Dec 5, 2024

refactor tests

f0f28ac
Select commit
Loading
Failed to load commit list.
Merged

feat: add support for dml_rate_limit #19679

refactor tests
f0f28ac
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-12-22 07:06:25 ago

0 / 8 tasks completed

8 tasks still to be completed

Details

Required Tasks

Task Status
The problem with recreating data stream is, the old data stream may still contain data chunks resutled from previous chunk splitting, recreating will lose them. Incomplete
This won't cause problem for SourceExecutor because it can still read those data from persistent store after recreating. Incomplete
This is a problem for DmlExecutor because those data chunks have already been removed from the DML data channel. Incomplete
I have written necessary rustdoc comments Incomplete
I have added necessary unit tests and integration tests Incomplete
I have added test labels as necessary. See details. Incomplete
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). Incomplete
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). Incomplete
All checks passed in ./risedev check (or alias, ./risedev c) Incomplete
My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) Incomplete
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Incomplete
src/frontend/src/telemetry.rs Incomplete
src/meta/src/telemetry.rs Incomplete
src/stream/src/telemetry.rs Incomplete
src/storage/compactor/src/telemetry.rs
Or calling report_event_common (src/common/telemetry_event/src/lib.rs) as if finding it hard to implement.
✨ Thank you for your contribution to RisingWave! ✨ Incomplete
Set dml rate limit on table + parallelism=1. Incomplete
Sleep 10s Incomplete
check number of rows in table ~10. Incomplete