-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): list streaming job from streaming_job
table & show info
#19134
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on Graphite |
streaming_job
table & show parallelism info
94e9b41
to
577e162
Compare
streaming_job
table & show parallelism infostreaming_job
table & show info
src/meta/src/controller/fragment.rs
Outdated
Expr::if_null( | ||
Expr::col((table::Entity, table::Column::Name)), | ||
Expr::if_null( | ||
Expr::col((source::Entity, source::Column::Name)), | ||
Expr::col((sink::Entity, sink::Column::Name)), | ||
), | ||
), | ||
"name", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems no better way to obtain the job name. 🤡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will there be any dangling shard sources here? 🥵
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a left join, so I guess all sources queried here are shared sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥵 All streaming jobs will be listed, including those being Creating
. Is this by design? Add FYI for replace table we will have a dummy record in streaming_job
table that doesn't have any associated catalogs in other tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
including those being
Creating
I think this can be useful for debugging and is frequently asked: #19044
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for replace table we will have a dummy record
This is just a temporary state I suppose, so perhaps it won't be too much problem. 🥺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it will cause panic because the name
will be NULL
and can't be mapped to String
in partial model StreamingJobInfo
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the following filter works or not. You can give it a try.
.filter(Expr::col(Alias::new("name")).is_not_null())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a fallback of <unknown>
@@ -53,14 +54,6 @@ export async function getRelationIdInfos(): Promise<RelationIdInfos> { | |||
return fragmentIds | |||
} | |||
|
|||
export async function getFragments(): Promise<TableFragments[]> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dead after #18272
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
0e717ab
to
c10a54b
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
List streaming jobs in dashboard by querying the
streaming_job
table in meta store, instead of querying different catalog tables separately. This gives more accurate results and extra info about streaming jobs.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.