Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iceberg): support s3 path style for iceberg source #19111

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Oct 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 requested review from Li0k and xxchan October 24, 2024 11:01
@chenzl25 chenzl25 added user-facing-changes Contains changes that are visible to users and removed type/feature labels Oct 24, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 5402 files.

Valid Invalid Ignored Fixed
2292 1 3109 0
Click to see the invalid file list
  • src/connector/src/parser/protobuf/recursive.rs

src/connector/src/parser/protobuf/recursive.rs Outdated Show resolved Hide resolved
@graphite-app graphite-app bot requested a review from a team October 24, 2024 11:46
@xxchan
Copy link
Member

xxchan commented Oct 25, 2024

Should we cherry-pick?

@chenzl25
Copy link
Contributor Author

Should we cherry-pick?

Yes. I think we can.

@chenzl25 chenzl25 enabled auto-merge October 25, 2024 04:23
@chenzl25 chenzl25 added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit ca75c21 Oct 25, 2024
35 of 36 checks passed
@chenzl25 chenzl25 deleted the dylan/support_s3_path_style_access_for_source branch October 25, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create iceberg source using MinIO and Hive Metastore.
2 participants