Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unexpected warning on undefined-field-padding-null error #19002

Merged
merged 2 commits into from
Nov 1, 2024
Merged

fix: unexpected warning on undefined-field-padding-null error #19002

merged 2 commits into from
Nov 1, 2024

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #16191

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@tabVersion
fix
96595b9 
Signed-off-by: tabVersion <[email protected]>
@github-actions github-actions bot added the type/fix Bug fix label Oct 18, 2024
@tabVersion
fix
ec742bc 
Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion requested a review from xiangjinwu October 18, 2024 08:55
@tabVersion tabVersion added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 03e9c95 Nov 1, 2024
32 of 35 checks passed
@tabVersion tabVersion deleted the tab/resolve-16191 branch November 1, 2024 05:59
github-actions bot pushed a commit that referenced this pull request Nov 1, 2024
@tabVersion
fix: unexpected warning on undefined-field-padding-null error (#19002)
4a4dfe1 
Signed-off-by: tabVersion <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 1, 2024
@github-actions @tabVersion
fix: unexpected warning on undefined-field-padding-null error (#19002) (
3e96f7c 
#19224)

Signed-off-by: tabVersion <[email protected]>
Co-authored-by: Bohan Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangjinwu xiangjinwu xiangjinwu approved these changes

Assignees
No one assigned
Labels
need-cherry-pick-release-2.1 type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(source): unexpected warning on undefined-field-padding-null error
2 participants
@tabVersion @xiangjinwu