-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cache): upgrade foyer to 0.12 and related deps #18822
Conversation
Signed-off-by: MrCroxx <[email protected]>
compilation fails for hashbrown 0.15: https://buildkite.com/risingwavelabs/pull-request/builds/59455#01927058-8ce4-4e74-8ed1-f5c2f047df6e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.with_buffer_pool_size( | ||
opts.meta_file_cache_flush_buffer_threshold_mb * MB, | ||
) // 128 MiB | ||
.with_clean_region_threshold( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a question: Is the value of clean_region_threshold
1.5 times the value of reclaimers
? Is this a specially tuned parameter for RW environments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is x1.5. But I think it may not affect that much.
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Changes:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.