Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cache): upgrade foyer to 0.12 and related deps #18822

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Oct 9, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Changes:

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@MrCroxx MrCroxx requested review from hzxa21 and Li0k October 9, 2024 08:14
@MrCroxx MrCroxx self-assigned this Oct 9, 2024
@MrCroxx MrCroxx requested a review from a team as a code owner October 9, 2024 08:14
@MrCroxx MrCroxx changed the title refactor(cache): upgrade foyer to 0.12, upgrade related deps refactor(cache): upgrade foyer to 0.12 and related deps Oct 9, 2024
@hzxa21
Copy link
Collaborator

hzxa21 commented Oct 9, 2024

Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.with_buffer_pool_size(
opts.meta_file_cache_flush_buffer_threshold_mb * MB,
) // 128 MiB
.with_clean_region_threshold(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question: Is the value of clean_region_threshold 1.5 times the value of reclaimers? Is this a specially tuned parameter for RW environments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is x1.5. But I think it may not affect that much.

@MrCroxx MrCroxx added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 7fa1dff Oct 11, 2024
29 of 30 checks passed
@MrCroxx MrCroxx deleted the xx/foyer-0.12 branch October 11, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants