fix(compatibility): always fill expr_context in StreamActor
#13888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeXiangWang
commented
Dec 8, 2023
| for (node_id, actor_ids) in fragments.worker_actors(include_inactive) { | ||
| let node_actor_ids = actor_maps.entry(node_id).or_insert_with(Vec::new); | ||
| node_actor_ids.extend(actor_ids); | ||
| for (node_id, actors) in fragments.worker_actors(include_inactive) { |
There was a problem hiding this comment.
Unrelated trivial renaming. The type of actor_ids here is Vec<StreamActor>.
KeXiangWang
added
the
ci/run-backwards-compat-tests
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13888 +/- ##
==========================================
- Coverage 68.34% 68.34% -0.01%
==========================================
Files 1528 1528
Lines 263330 263340 +10
==========================================
+ Hits 179976 179979 +3
- Misses 83354 83361 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chenzl25
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix #13883.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.