Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fix apt install failed #13873

Merged
merged 3 commits into from
Dec 8, 2023
Merged

fix(docker): fix apt install failed #13873

merged 3 commits into from
Dec 8, 2023

Conversation

huangjw806
Copy link
Contributor

@huangjw806 huangjw806 commented Dec 8, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

It seems that we must update before apt-get install, otherwise will failed.

failed pipeline: https://buildkite.com/risingwavelabs/docker/builds/14838

test pipeline: https://buildkite.com/risingwavelabs/docker/builds/14849

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@huangjw806 huangjw806 requested review from xxchan and chenzl25 December 8, 2023 07:23
@github-actions github-actions bot added the type/fix Bug fix label Dec 8, 2023
@xxchan xxchan changed the title fix(docker): fix docker install faild fix(docker): fix apt install failed Dec 8, 2023
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. This is introduced intentionally to help reduce apt update network failure (#7734) 😕

@xxchan
Copy link
Member

xxchan commented Dec 8, 2023

The weird thing is

  • why cached apt update leads to apt install error
  • why apt install is not cached...

@huangjw806 huangjw806 added this pull request to the merge queue Dec 8, 2023
@huangjw806
Copy link
Contributor Author

The weird thing is

  • why cached apt update leads to apt install error
  • why apt install is not cached...

It's very weird, but let's merge it in first to solve the docker build failure, otherwise it will block a lot of things.

@xxchan
Copy link
Member

xxchan commented Dec 8, 2023

why cached apt update leads to apt install error

Because the pkg is updated

http://security.ubuntu.com/ubuntu/pool/main/c/curl/

image image

@xxchan
Copy link
Member

xxchan commented Dec 8, 2023

Indeed, if the cache works properly, the later apt update should be a no-op. And we don't need to remove that at all :)

So apt update should be always added.

Merged via the queue into main with commit b87bcc3 Dec 8, 2023
11 of 12 checks passed
@huangjw806 huangjw806 deleted the jianwei/fix-docker branch December 8, 2023 08:15
huangjw806 added a commit that referenced this pull request Dec 11, 2023
zwang28 pushed a commit that referenced this pull request Jan 9, 2024
zwang28 pushed a commit that referenced this pull request Jan 9, 2024
zwang28 pushed a commit that referenced this pull request Jan 10, 2024
zwang28 pushed a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants