Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): standalone mode for docker compose with different object storage #13854

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Dec 7, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title, has verified via oss.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fcea158) 68.31% compared to head (bf60b67) 68.31%.
Report is 10 commits behind head on main.

Files Patch % Lines
src/connector/src/common.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13854   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files        1527     1527           
  Lines      262562   262562           
=======================================
+ Hits       179360   179374   +14     
+ Misses      83202    83188   -14     
Flag Coverage Δ
rust 68.31% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wcy-fdu wcy-fdu requested a review from kwannoel December 8, 2023 08:03
@kwannoel kwannoel requested a review from lmatz December 8, 2023 08:20
@kwannoel
Copy link
Contributor

kwannoel commented Dec 8, 2023

Do we have tests for these in CI? e.g. via integration tests.

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Dec 9, 2023

Do we have tests for these in CI? e.g. via integration tests.

A bit hard to test in CI, as the changes in these files were the same, I manually tested one of the OSS.

@kwannoel
Copy link
Contributor

kwannoel commented Dec 11, 2023

Do we have tests for these in CI? e.g. via integration tests.

A bit hard to test in CI, as the changes in these files were the same

Not quite sure what you mean.

I think we can run some basic test:

  1. Start cluster
  2. create some table, create some mv.
  3. Restart cluster
  4. Make sure data still remains.

This will verify that the docker configuration is correct (i.e. components can connect with each other),
and will also ensure that object store actually works, because after cluster restarted, the data can be recovered.

You may do so in a separate PR.

I think we should test it in our CI, since it's already user-facing. e.g. https://docs.risingwave.com/docs/current/risingwave-docker-compose/#google-cloud-storage-alibaba-cloud-oss-or-azure-blob-storage.

@wcy-fdu wcy-fdu added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit a3c71aa Dec 11, 2023
8 of 9 checks passed
@wcy-fdu wcy-fdu deleted the wcy/docker_standalone branch December 11, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants