-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): standalone mode for docker compose with different object storage #13854
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13854 +/- ##
=======================================
Coverage 68.31% 68.31%
=======================================
Files 1527 1527
Lines 262562 262562
=======================================
+ Hits 179360 179374 +14
+ Misses 83202 83188 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Do we have tests for these in CI? e.g. via integration tests. |
A bit hard to test in CI, as the changes in these files were the same, I manually tested one of the OSS. |
Not quite sure what you mean. I think we can run some basic test:
This will verify that the docker configuration is correct (i.e. components can connect with each other), You may do so in a separate PR. I think we should test it in our CI, since it's already user-facing. e.g. https://docs.risingwave.com/docs/current/risingwave-docker-compose/#google-cloud-storage-alibaba-cloud-oss-or-azure-blob-storage. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title, has verified via oss.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.