Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pgwire): avoid error log for health check #13849

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Dec 7, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 enabled auto-merge December 7, 2023 05:25
@chenzl25 chenzl25 added this pull request to the merge queue Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (fcea158) 68.31% compared to head (9ea5b9d) 68.30%.
Report is 18 commits behind head on main.

Files Patch % Lines
src/utils/pgwire/src/pg_message.rs 72.22% 5 Missing ⚠️
src/utils/pgwire/src/pg_protocol.rs 0.00% 5 Missing ⚠️
src/connector/src/common.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13849      +/-   ##
==========================================
- Coverage   68.31%   68.30%   -0.01%     
==========================================
  Files        1527     1527              
  Lines      262562   262584      +22     
==========================================
- Hits       179360   179351       -9     
- Misses      83202    83233      +31     
Flag Coverage Δ
rust 68.30% <54.16%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2023
@chenzl25 chenzl25 requested review from BugenZhao and xxchan December 7, 2023 08:25
@chenzl25 chenzl25 requested a review from xxchan December 7, 2023 09:26
@chenzl25 chenzl25 requested a review from BugenZhao December 8, 2023 08:48
@chenzl25 chenzl25 added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit 5d7f327 Dec 11, 2023
6 of 7 checks passed
@chenzl25 chenzl25 deleted the dylan/avoid_error_log_for_health_check branch December 11, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend unexpected end of file error all the time
4 participants