Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object store): support obs #13844

Merged
merged 2 commits into from
Dec 7, 2023
Merged

feat(object store): support obs #13844

merged 2 commits into from
Dec 7, 2023

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Dec 7, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Support obs in kernel side, and next pr will add the docker compose file for it.
Should use hummock+obs as state store url.
image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (2fba274) 68.32% compared to head (5a3e5da) 68.30%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/object_store/src/object/opendal_engine/obs.rs 0.00% 28 Missing ⚠️
src/object_store/src/object/mod.rs 12.50% 7 Missing ⚠️
src/risedevtool/src/task/utils.rs 0.00% 4 Missing ⚠️
.../src/object/opendal_engine/opendal_object_store.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13844      +/-   ##
==========================================
- Coverage   68.32%   68.30%   -0.02%     
==========================================
  Files        1527     1528       +1     
  Lines      262564   262605      +41     
==========================================
- Hits       179389   179376      -13     
- Misses      83175    83229      +54     
Flag Coverage Δ
rust 68.30% <2.43%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wcy-fdu wcy-fdu requested a review from hzxa21 December 7, 2023 03:40
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can you give an example in the PR description on what the state store url and configuration looks like in order to use obs?

@hzxa21
Copy link
Collaborator

hzxa21 commented Dec 7, 2023

cc @neverchanje do we need to mark this as a user facing change and release it in the doc as an supported object store backend?

@neverchanje neverchanje added the user-facing-changes Contains changes that are visible to users label Dec 7, 2023
@neverchanje
Copy link
Contributor

Yes. It's a user-facing feature. The doc team should be aware regardless of whether it's appropriate to document it.

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Dec 7, 2023

Yes. It's a user-facing feature. The doc team should be aware regardless of whether it's appropriate to document it.

Yes, this pr is only the kernel side. I will open a pr about docker compose via obs, and need support from doc team and RisingWave operator as well.

Will delivered to customer when all components and documentation are ready.

@wcy-fdu wcy-fdu added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit ddfa85b Dec 7, 2023
14 of 15 checks passed
@wcy-fdu wcy-fdu deleted the wcy/support_obs branch December 7, 2023 06:10
github-actions bot pushed a commit that referenced this pull request Dec 8, 2023
wcy-fdu added a commit that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants