-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(object store): support obs #13844
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13844 +/- ##
==========================================
- Coverage 68.32% 68.30% -0.02%
==========================================
Files 1527 1528 +1
Lines 262564 262605 +41
==========================================
- Hits 179389 179376 -13
- Misses 83175 83229 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can you give an example in the PR description on what the state store url and configuration looks like in order to use obs?
cc @neverchanje do we need to mark this as a user facing change and release it in the doc as an supported object store backend? |
Yes. It's a user-facing feature. The doc team should be aware regardless of whether it's appropriate to document it. |
Yes, this pr is only the kernel side. I will open a pr about docker compose via obs, and need support from doc team and RisingWave operator as well. Will delivered to customer when all components and documentation are ready. |
Co-authored-by: congyi wang <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support obs in kernel side, and next pr will add the docker compose file for it.
![image](https://private-user-images.githubusercontent.com/58715567/288621500-ec8140c5-4169-47e8-bd59-4cd3bbf8d948.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2ODU5NzEsIm5iZiI6MTczOTY4NTY3MSwicGF0aCI6Ii81ODcxNTU2Ny8yODg2MjE1MDAtZWM4MTQwYzUtNDE2OS00N2U4LWJkNTktNGNkM2JiZjhkOTQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDA2MDExMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVkZTBhYjg3MjljOWVmNGQyMTVkMzAxMGQ5MGI0NDU1Y2RiMmFhNTMzZjc0NmU5NzEwOGEyNGQ2YTRhMjVlODEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.15ATXzjAJYrrzAkD9r08pNAc1INrhKW5mpvN-2DIs9w)
Should use
hummock+obs
as state store url.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.