Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support lc_collate and lc_ctype session config #12404

Closed
wants to merge 2 commits into from
Closed

feat: Support lc_collate and lc_ctype session config #12404

wants to merge 2 commits into from

Conversation

jetjinser
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

For pgAdmin #11048 and tableau #10459

As of now, lc_collate and lc_ctype can always be shown as C but not set.
I'm not sure yet if this locale setting can actually be implemented.

see: https://www.postgresql.org/docs/current/sql-show.html:

  • LC_COLLATE Shows the database's locale setting for collation (text ordering).
  • LC_CTYPE Shows the database's locale setting for character classification.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates.

Release note

Should we wait for the refactoring #10697 to complete first?

@jetjinser jetjinser requested a review from stdrc October 9, 2023 11:32
@jetjinser jetjinser closed this by deleting the head repository Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant