Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump moka from 0.11.3 to 0.12.0 #12403

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 18, 2023

Bumps moka from 0.11.3 to 0.12.0.

Changelog

Sourced from moka's changelog.

Version 0.12.0

Note v0.12.0 has major breaking changes on the API and internal behavior.

  • sync caches are no longer enabled by default: Please use a crate feature sync to enable it.

  • No more background threads: All cache types future::Cache, sync::Cache, and sync::SegmentedCache no longer spawn background threads.

    • The scheduled-thread-pool crate was removed from the dependency.
    • Because of this change, many private methods and some public methods under the future module were converted to async methods. You may need to add .await to your code for those methods.
  • Immediate notification delivery: The notification::DeliveryMode enum for the eviction listener was removed. Now all cache types behave as if the Immediate delivery mode is specified.

Please read the MIGRATION-GUIDE.md for more details.

Changed

  • Removed the thread pool from future cache (#294[gh-pull-0294]) and sync caches (#316[gh-pull-0316]).
  • Improved async cancellation safety of future::Cache. (#309[gh-pull-0309])

Fixed

  • Fixed a bug that an internal do_insert_with_hash method gets the current Instant too early when eviction listener is enabled. (#322[gh-issue-0322])
Commits
  • 0b160cd Merge pull request #326 from moka-rs/prepare-v0.12.0
  • 42149b0 Remove invalidator_enabled field from sync::base_cache::Inner
  • 6dce691 Update the README and CHANGELOG
  • 13bc37f Bump the version to v0.12.0
  • dccc75b Merge pull request #325 from peter-scholtens/patch-1
  • 5428903 typo in weblink
  • 51e099c Merge pull request #324 from moka-rs/get-timestamp-after-locking
  • 650be41 Update the change log
  • 70880ed Update the doc for Expiry trait for clarity
  • ffb71de Fix an issue that the last modified time might be get a little too early
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps [moka](https://github.com/moka-rs/moka) from 0.11.3 to 0.12.0.
- [Changelog](https://github.com/moka-rs/moka/blob/main/CHANGELOG.md)
- [Commits](moka-rs/moka@v0.11.3...v0.12.0)

---
updated-dependencies:
- dependency-name: moka
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner September 18, 2023 19:01
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 18, 2023
@BugenZhao BugenZhao self-assigned this Sep 19, 2023
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to

@@ -84,12 +79,7 @@ pub trait RpcClient: Send + Sync + 'static + Clone {
pub struct RpcClientPool<S> {
connection_pool_size: u16,

#[cfg(not(madsim))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to enable Moka cache under madsim according to the change log. cc @wangrunji0408

No more background threads: All cache types future::Cache, sync::Cache, and sync::SegmentedCache no longer spawn background threads.

The scheduled-thread-pool crate was removed from the dependency.
Because of this change, many private methods and some public methods under the future module were converted to async methods. You may need to add .await to your code for those methods.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #12403 (9205343) into main (4dadb7c) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #12403      +/-   ##
==========================================
- Coverage   69.76%   69.76%   -0.01%     
==========================================
  Files        1424     1424              
  Lines      236247   236244       -3     
==========================================
- Hits       164826   164819       -7     
- Misses      71421    71425       +4     
Flag Coverage Δ
rust 69.76% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/connector/src/parser/avro/schema_resolver.rs 0.00% <0.00%> (ø)
src/rpc_client/src/lib.rs 90.21% <ø> (-0.31%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit e19a536 Sep 19, 2023
@wangrunji0408 wangrunji0408 deleted the dependabot/cargo/moka-0.12.0 branch September 19, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants