Skip to content

Commit

Permalink
minor
Browse files Browse the repository at this point in the history
  • Loading branch information
StrikeW committed Oct 31, 2023
1 parent f540c36 commit 21e059a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/frontend/src/handler/create_table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,6 @@ pub async fn handle_create_table(
let context = OptimizerContext::from_handler_args(handler_args);
let source_schema = check_create_table_with_source(context.with_options(), source_schema)?;
let col_id_gen = ColumnIdGenerator::new_initial();
// let properties = context.with_options().inner().clone().into_iter().collect();

let ((plan, source, table), job_type) = match (source_schema, cdc_table_info.as_ref()) {
(Some(source_schema), None) => (
Expand Down
2 changes: 1 addition & 1 deletion src/meta/service/src/ddl_service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,8 @@ impl DdlService for DdlServiceImpl {
});
}

// The id of stream job has been set above
let stream_job = StreamingJob::Source(source);

let version = self
.ddl_controller
.run_command(DdlCommand::CreateStreamingJob(
Expand Down
4 changes: 3 additions & 1 deletion src/meta/src/manager/streaming_job.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ impl StreamingJob {
index_table.id = id;
}
StreamingJob::Source(_) => {
// do nothing
// The id of source is set in `DdlServiceImpl::create_source`,
// so do nothing here.
unreachable!()
}
}
}
Expand Down

0 comments on commit 21e059a

Please sign in to comment.