Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove schema.registry.name.strategy #2660

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

tabVersion
Copy link
Contributor

Description

we do not need schema.registry.name.strategy because now we no longer get key schema from schema registry.
Keeping the default behavior to <topic name>-value as value schema subject

Related code PR

Related doc issue

Resolve

Rendered preview

Checklist

  • I have checked the doc site preview, and the updated parts look good.
  • I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (emile-00, hengm3467, & WanYixian).

docs/ingest/supported-sources-and-formats.md Outdated Show resolved Hide resolved
docs/ingest/supported-sources-and-formats.md Outdated Show resolved Hide resolved
docs/ingest/supported-sources-and-formats.md Outdated Show resolved Hide resolved
Copy link
Contributor

@WanYixian WanYixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since which version does this change apply to, 2.0 or 2.1? 🤔

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2660.d2fbku9n2b6wde.amplifyapp.com

@tabVersion
Copy link
Contributor Author

Since which version does this change apply to, 2.0 or 2.1? 🤔

We can remove it since 2.0.

Copy link
Contributor

@WanYixian WanYixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion tabVersion merged commit def829d into main Oct 11, 2024
2 of 3 checks passed
@tabVersion tabVersion deleted the tab/remove-schema-registry branch October 11, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants