Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add openai function examples #242

Merged
merged 6 commits into from
Feb 17, 2025
Merged

add openai function examples #242

merged 6 commits into from
Feb 17, 2025

Conversation

hengm3467
Copy link
Collaborator

WanYixian
WanYixian approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@WanYixian WanYixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sql/udfs/use-udfs-in-python.mdx Outdated Show resolved Hide resolved
sql/udfs/use-udfs-in-python.mdx Outdated Show resolved Hide resolved
sql/udfs/use-udfs-in-python.mdx Outdated Show resolved Hide resolved
@stdrc
Copy link
Member

stdrc commented Feb 14, 2025

Why not use text embedding as an example? Seems more useful. Also, recently we added batch=True argument to allow batching call.

See arrow-udf/arrow-udf#108 for text_embedding example. See https://github.com/risingwavelabs/awesome-stream-processing/blob/eric/rag_demo/04-rag-demo/README.md for a full RAG example (embedded JS UDF is used in this page).

@hengm3467
Copy link
Collaborator Author

Why not use text embedding as an example? Seems more useful. Also, recently we added batch=True argument to allow batching call.

See arrow-udf/arrow-udf#108 for text_embedding example. See https://github.com/risingwavelabs/awesome-stream-processing/blob/eric/rag_demo/04-rag-demo/README.md for a full RAG example (embedded JS UDF is used in this page).

Thanks! @stdrc And feel free to make changes directly.

hengm3467 and others added 2 commits February 14, 2025 21:10
@hengm3467 @WanYixian
Update sql/udfs/use-udfs-in-python.mdx
d28b967 
Co-authored-by: IrisWan <[email protected]>
Signed-off-by: hengm3467 <[email protected]>
@hengm3467 @WanYixian
Update sql/udfs/use-udfs-in-python.mdx
7af50cc 
Co-authored-by: IrisWan <[email protected]>
Signed-off-by: hengm3467 <[email protected]>
@stdrc stdrc self-assigned this Feb 14, 2025
@stdrc
update
90b9ed2 
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc requested a review from WanYixian February 17, 2025 09:02
@stdrc
fix link
3ef028c 
Signed-off-by: Richard Chien <[email protected]>
WanYixian
WanYixian approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@WanYixian WanYixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks!

@stdrc stdrc merged commit 31601a4 into main Feb 17, 2025
4 checks passed
@stdrc stdrc deleted the update-udf-examples branch February 17, 2025 09:21
yufansong
yufansong reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@yufansong yufansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufansong yufansong yufansong left review comments

@WanYixian WanYixian WanYixian approved these changes

Assignees

@stdrc stdrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hengm3467 @stdrc @yufansong @WanYixian