Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix codeblock language for /sql/function folder #237

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix: fix codeblock language for /sql/function folder #237

merged 1 commit into from
Feb 14, 2025

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Feb 12, 2025 •
edited
Loading

  • SQL queries and function syntaxes should be put in ```sql blocks.
  • SQL outputs should be in plain ``` blocks.
  • When referencing something like a variable/parameter/function name, you probably want to use `some_identifier` instead of _some\_identifier_.

Rendered: https://risingwavelabs-rc-fix-codeblock-lang-for-sql-functions.mintlify.app/sql/functions/overview

@stdrc stdrc changed the title fix codeblock language for sql function folder fix: fix codeblock language for sql function folder Feb 12, 2025
@stdrc Graphite App
Copy link
Member Author

stdrc commented Feb 12, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@stdrc stdrc changed the title fix: fix codeblock language for sql function folder fix: fix codeblock language for sql/function folder Feb 12, 2025
@stdrc stdrc changed the title fix: fix codeblock language for sql/function folder fix: fix codeblock language for /sql/function folder Feb 12, 2025
@stdrc stdrc marked this pull request as ready for review February 12, 2025 14:13
@stdrc stdrc requested a review from WanYixian February 12, 2025 14:14
@stdrc stdrc mentioned this pull request Feb 12, 2025
Merged
@stdrc stdrc enabled auto-merge (squash) February 12, 2025 14:37
WanYixian
WanYixian approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@WanYixian WanYixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for pointing it out

@stdrc stdrc merged commit fbe2ab4 into main Feb 14, 2025
4 checks passed
@stdrc stdrc deleted the rc/fix-codeblock-lang-for-sql-functions branch February 14, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WanYixian WanYixian WanYixian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stdrc @WanYixian