Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private link related connection #141

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

WanYixian
Copy link
Collaborator

Description

Remove private link related connection in Kafka source & sink

Related code PR

risingwavelabs/risingwave#18975

Related doc issue

Resolve https://github.com/risingwavelabs/risingwave-docs-legacy/issues/2740

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr's description has significant diff from rw's behavior.
We removed legacy CONNECTION usage, ie. creating source/sink with private-link connection. It does not mean we remove support for private link either.

integrations/sources/kafka.mdx Show resolved Hide resolved
@WanYixian WanYixian merged commit c941cea into main Dec 20, 2024
3 checks passed
@WanYixian WanYixian deleted the wyx/resolve_legacy_2740 branch December 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants