Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: utilize Scarf Gateway endpoint for RisingWave image and operator helm charts #89

Merged
merged 2 commits into from
May 24, 2024

Conversation

arjundevarajan
Copy link
Contributor

This PR updates the RisingWave configuration for helm charts to fetch the RisingWave main container image as well as the RisingWave operator container image via a Scarf endpoint. This allows RisingWave maintainers to collect basic de-identified download and adoption metrics. It does not affect where the containers are being hosted, as Scarf is only redirecting traffic back to GHCR.

This change was suggested by the RisingWave product team in direct discussions. To test this, download RisingWave using the new endpoint (e.g. docker pull risingwave.docker.scarf.sh/risingwavelabs/risingwave) and verify that the risingwavelabs/risingwave container downloads without issue.

@alicelyy
Copy link

Verified docker pull successful:

➜  ~ docker pull risingwave.docker.scarf.sh/risingwavelabs/risingwave
Using default tag: latest
latest: Pulling from risingwavelabs/risingwave
ca6fd4ca81e0: Pull complete
59850338221a: Pull complete
e768fb86ff00: Pull complete
e3a663b20ee7: Pull complete
4eb3c6818fed: Pull complete
00009779bb37: Pull complete
db704c6aa20d: Pull complete
b6ebe865eadc: Pull complete
6df207a26781: Pull complete
85a70973c738: Pull complete
Digest: sha256:298e488129a9c9be2feb2af5ca3c23127f69114fb2c915cbfb432f8c671f02e1
Status: Downloaded newer image for risingwave.docker.scarf.sh/risingwavelabs/risingwave:latest
risingwave.docker.scarf.sh/risingwavelabs/risingwave:latest
➜  ~ docker pull risingwave.docker.scarf.sh/risingwavelabs/risingwave
➜  ~ docker pull ghcr.io/risingwavelabs/risingwave
Using default tag: latest
latest: Pulling from risingwavelabs/risingwave
Digest: sha256:298e488129a9c9be2feb2af5ca3c23127f69114fb2c915cbfb432f8c671f02e1
Status: Downloaded newer image for ghcr.io/risingwavelabs/risingwave:latest
ghcr.io/risingwavelabs/risingwave:latest

@KeXiangWang KeXiangWang added this pull request to the merge queue May 24, 2024
Merged via the queue into risingwavelabs:main with commit f85f9c4 May 24, 2024
1 check passed
@arkbriar
Copy link
Collaborator

Revert because I, as the maintainer, wasn't notified about the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants