Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat & fix: add options for prometheus job discovery annotations, fix… #86

Merged
merged 2 commits into from
May 21, 2024
Merged

feat & fix: add options for prometheus job discovery annotations, fix… #86

merged 2 commits into from
May 21, 2024

Conversation

arkbriar
Copy link
Collaborator

@arkbriar arkbriar commented May 15, 2024 •
edited
Loading

… ports of standalone sts

Option:

monitor:
  annotations:
    enabled: true

When enabled, the following annotations will be added to Pods:

prometheus.io/scrape: "true"
prometheus.io/port: "<port-number>"
prometheus.io/path: "/metrics"

These are all of a common set of annotations used when using Prometheus k8s service (job) discovery. They should cover most of the cases.

@arkbriar arkbriar requested a review from wjf3121 May 15, 2024 08:23
wjf3121
wjf3121 approved these changes May 21, 2024
View reviewed changes
Copy link

@wjf3121 wjf3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkbriar arkbriar added this pull request to the merge queue May 21, 2024
@arkbriar arkbriar removed this pull request from the merge queue due to a manual request May 21, 2024
@arkbriar arkbriar force-pushed the shunjie/add-option-for-prometheus-discovery-annotations branch from f2d2cd0 to a221517 Compare May 21, 2024 09:00
@arkbriar arkbriar enabled auto-merge May 21, 2024 09:00
@arkbriar arkbriar added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit ed14113 May 21, 2024
1 check passed
@arkbriar arkbriar deleted the shunjie/add-option-for-prometheus-discovery-annotations branch May 21, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjf3121 wjf3121 wjf3121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arkbriar @wjf3121