feat: add pre-stop hook to unregister a compute node before its pod's termination

charts/risingwave/templates/compute-sts.yaml

@@ -123,6 +123,17 @@ spec:
         command:
         - /risingwave/bin/risingwave
         - compute-node
+        {{- if .Values.computeComponent.autoDeregistration.enabled }}
+        lifecycle:
+          preStop:
+            exec:
+              command:
+              - bash
+              - -c
+              - >-
+                /risingwave/bin/risingwave ctl meta unregister-workers --yes \
+                  --workers ${POD_NAME}.{{ include "risingwave.computeHeadlessServiceName" . }}.{{.Release.Namespace}}.svc:{{ .Values.ports.compute.svc }}
+        {{- end }}
         {{- end }}
         ports:
         - containerPort: {{ .Values.ports.compute.svc }}

charts/risingwave/tests/compute_auto_deregistration_test.yaml

@@ -0,0 +1,31 @@
+suite: Test compute auto deregistration
+templates:
+- compute-sts.yaml
+chart:
+  appVersion: 1.0.0
+  version: 0.0.1
+tests:
+- it: lifecycle doesn't exist when disabled
+  set:
+    computeComponent:
+      autoDeregistration:
+        enabled: false
+  asserts:
+  - notExists:
+      path: spec.template.spec.containers[0].lifecycle
+- it: lifecycle exists when enabled
+  set:
+    computeComponent:
+      autoDeregistration:
+          enabled: true
+  asserts:
+  - exists:
+      path: spec.template.spec.containers[0].lifecycle
+  - equal:
+      path: spec.template.spec.containers[0].lifecycle.preStop.exec.command
+      value:
+      - bash
+      - -c
+      - >-
+        /risingwave/bin/risingwave ctl meta unregister-workers --yes \
+          --workers ${POD_NAME}.RELEASE-NAME-risingwave-compute-headless.NAMESPACE.svc:5688

charts/risingwave/values.yaml

@@ -1061,6 +1061,13 @@ computeComponent:
     whenDeleted: Delete
     whenScaled: Delete
 
+  ## @param autoDeregistration Auto-deregistration of compute pods. If enabled, compute pods will be
+  ## automatically deregistered from the meta store when they are deleted.
+  ##
+  autoDeregistration:
+    ## @param autoDeregistration.enabled Enable auto-deregistration.
+    enabled: false
+
 compactorComponent:
   ## @param compactorComponent.podLabels Labels to add to the component pods.
   ##