Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sql meta backends and local fs state store backend #52

Merged
merged 11 commits into from
Mar 20, 2024

Conversation

arkbriar
Copy link
Collaborator

@arkbriar arkbriar commented Mar 14, 2024

  • Support SQL backends sqlite, mysql and postgresql
  • Support local FS state store backend
  • Support volumeClaimTemplates and persistentVolumeClaimRetentionPolicy in standalone, meta and compute to persistent local files
  • Add examples and test cases.
  • Do a release.

After the PR's merged, one can start a pure standalone (1 pod only) with the following command:

helm install -f examples/dev/dev.values.yaml risingwave risingwavelabs/risingwave

The file examples/dev/dev.values.yaml can be found here.

Signed-off-by: arkbriar <[email protected]>
@arkbriar
Copy link
Collaborator Author

arkbriar commented Mar 14, 2024

Also, if a user just want to try out RisingWave without considering data persistence, the following command shall work on bare k8s.

helm install --set metaStore.sqlite.enabled=true,stateStore.localFs.enabled=true,standalone.enabled=true risingwave risingwavelabs/risingwave

@arkbriar
Copy link
Collaborator Author

Tested with sqlite, PG and MySQL, and RW version v1.7.1.

Conclusions:

  • RW works well with PG and sqlite.
  • However, RW refused to start with MySQL. It's a bug and I have let @yezizp2012 know.
mismatched types; Rust type `core::option::Option<chrono::naive::datetime::NaiveDateTime>` (as SQL type `DATETIME`) is not compatible with SQL type `TIMESTAMP`

@yezizp2012
Copy link
Contributor

Tested with sqlite, PG and MySQL, and RW version v1.7.1.

Conclusions:

  • RW works well with PG and sqlite.
  • However, RW refused to start with MySQL. It's a bug and I have let @yezizp2012 know.
mismatched types; Rust type `core::option::Option<chrono::naive::datetime::NaiveDateTime>` (as SQL type `DATETIME`) is not compatible with SQL type `TIMESTAMP`

Opened a PR to fix several issues when using MySQL: risingwavelabs/risingwave#15717. There is only one issue left now, and I am considering how to elegantly solve it.

Base automatically changed from test/test-cases-for-workloads to main March 19, 2024 07:40
Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for the job!

@arkbriar arkbriar added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit 25028dc Mar 20, 2024
1 check passed
@arkbriar arkbriar deleted the feat/sql-meta-backends branch March 20, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants