Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init the driver app #1

Merged
merged 1 commit into from
Nov 14, 2022
Merged

feat: init the driver app #1

merged 1 commit into from
Nov 14, 2022

Conversation

TennyZhuang
Copy link
Contributor

Signed-off-by: TennyZhuang [email protected]

Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang
Copy link
Contributor Author

Will add README and ci checker later

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangrunji0408
Copy link
Member

A silly question: why don't we put it together with sqllogictest-rs? 🥵

Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TennyZhuang
Copy link
Contributor Author

A silly question: why don't we put it together with sqllogictest-rs? 🥵

Not sure it's a good practice to create a cross-lang project

@TennyZhuang
Copy link
Contributor Author

But it's also acceptable to me

@TennyZhuang TennyZhuang merged commit dfe5215 into main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants