-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for E extension #646
base: master
Are you sure you want to change the base?
Conversation
This required splitting many of the AST constructors.
It would be really nice to have this as an "initialisation time" option rather than yet another compile time option. I think @Alasdair 's new config system will take care of
I think there's no harm having |
That also makes it easier to support runtime enabling/disabling of E, by writing |
Although... if we do support that then you can't change the |
We could have a split between a compile-time only E build where regidx is 4 bits and a runtime E mode where it just restricts the set of available GPRs. The specification does specifically mention that E can be enabled and disabled by writing misa[I] so we do need to support the second option. |
Certainly the compile-time E-only option is a more attractive base for CHERIoT, and I could imagine utility for a compile-time I-only option (as in this PR), but maybe that's less useful. I think Someone Who Isn't Me gets to do the dynamic E/I case, but I would love to see it done and hopefully this PR is at least not a terrible place to start. |
Is there any point having the compile-time version if we support the runtime version though and make I guess it helps with the formal and SV backends?
What's SWIM? |
Split out from and sitting atop #617, the last commit here is the salient one. This factors out the I base register system, with its 32 registers, and then offers a parallel instantiation for the E base register system, with its 16 registers.
Note that this is subtly wrong for RVnnEZicsr systems until #645 or something much like it lands.