Clarify multiple VA to PA mapping #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak0414
reviewed
Nov 20, 2024
src/mte_tag.adoc
Outdated
| @@ -218,6 +218,11 @@ splitted stores. | |||
| A memory access (load or store) to some virtual address `va` can not bypass | |||
| the older store initiated by `settag/setinvtag rs1=va`. | |||
|
|
|||
| This specification defines tag as the entitiy attached to virtual addresses. | |||
There was a problem hiding this comment.
s/entitiy attached/entity associated/
src/mte_tag.adoc
Outdated
| This specification defines tag as the entitiy attached to virtual addresses. | ||
| It is software's responsibility to ensure that the tags are appropriately set | ||
| on the virtual addresses even though some of them map to the same physical | ||
| address(es). |
There was a problem hiding this comment.
Can we re-word this
"""
It is software's responsibility to ensure that the tags are appropriately set
on the virtual addresses even though some of them map to the same physical
address(es)
"""
to something like
"""
In case of aliasing (multiple virtual addresses map to same physical address), it is software's
responsibility to ensure that the tags are set correctly for respective virtual address prior to
memory accesses via aliased virtual address.
"""
There was a problem hiding this comment.
Revised as suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note on software's responsibility because tags are defined on VA.