Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated Ssqosid extension #1705

Closed
wants to merge 1 commit into from
Closed

Integrated Ssqosid extension #1705

wants to merge 1 commit into from

Conversation

ved-rivos
Copy link
Collaborator

No description provided.

aswaterman
aswaterman approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly scanned the spec and didn't see other cases where we included in the mainline text the priv version number that added a feature. I'll strip that from this text and instead add a changelog entry.

I'll also fix a typo (there is a stray 55).

@aswaterman
Copy link
Member

Manually merged via 6114bf9

@aswaterman aswaterman closed this Nov 2, 2024
@ved-rivos
Copy link
Collaborator Author

Thanks!

@ved-rivos
Copy link
Collaborator Author

@aswaterman - "The P1P13 bit in mstateen0 controls access to the hedelegh introduced by Privileged Specification Version
1.13." Was this the text you intended to add to change log? If so it is still in there.

@aswaterman
Copy link
Member

I created a new changelog with only one entry for P1P14. (I didn't change the changelog for the ratified spec, which includes the P1P13 entry.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ved-rivos @aswaterman