Adds back bits 57 & 56 #1645
Adds back bits 57 & 56 #1645
Conversation
Adds back bits 57 & 56 to Sscofpmf and Smcntrpmf.
|
Fixes #1578 (comment) |
Fixing 57:0 to be 57
|
So everyone is in agreement and this is good to merge now? |
|
I don't see any changes based on our comments? There should only be 1 file changed (sscofpmf.adoc). |
|
@bcstrongx for smcntrpmf, there is one change: |
Ahh I see this now. I was referring to this in my earlier comment. Please ignore my previous comment if this is what going to be planned change for smcntrpmf. |
|
@ved-rivos I removed that text a while back: 57:0 are all reserved in m{instret|cycle}cfg. |
As per the conversation on the original PR, it was decided that no changes to Smcntrpmf are required.
As per conversation, no changes are required to Smcntrpmf
|
So only Sscofpmf has changes now, with the exception of the deletion of an extra space at the end of a line in Smcntrpmf. With approvals, this can be merged now? |
LGTM! |
After multiple discussions within ARC, it was decided to restore back the bits 57-56 in the mhpmeventX. riscv/riscv-isa-manual#1645 Signed-off-by: Atish Patra <[email protected]>
After multiple discussions within ARC, it was decided to restore back the bits 57-56 in the mhpmeventX. riscv/riscv-isa-manual#1645 Signed-off-by: Atish Patra <[email protected]>
After multiple discussions within ARC, it was decided to restore back the bits 57-56 in the mhpmeventX. riscv/riscv-isa-manual#1645 Signed-off-by: Atish Patra <[email protected]>
After multiple discussions within ARC, it was decided to restore back the bits 57-56 in the mhpmeventX. riscv/riscv-isa-manual#1645 Signed-off-by: Atish Patra <[email protected]>
Adds back bits 57 & 56 to Sscofpmf and Smcntrpmf. @gfavor and @bcstrongx , can you please make sure I added these bits back correctly?