Smstateen - Integration of State Enable extension chapter. #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the applicable adoc content from the Smstateen repository to the smstateen.adoc file and included in the Priv header. Set chapter anchor, titled to be consistent with other extension chapter titles in priv and set header levels appropriately.
wmat
changed the title
This was referenced Feb 7, 2024
ved-rivos
reviewed
Feb 29, 2024
src/smstateen.adoc
Outdated
|
|
||
| bit 62 - `senvcfg` | ||
|
|
||
| bit 63 - `sstateen0` |
There was a problem hiding this comment.
Should be converted into a register layout diagram. The diagram should use the short names.
There was a problem hiding this comment.
Prior to merge or can this be done post merge? If pre-merge, someone will have to do it.
There was a problem hiding this comment.
@ved-rivos so what do you think, can the register layout diagram be added post chapter merge?
Set the version of the State Eneable Extension chspter to 1.0.0
Applying Ved's reg diagrams and shortnames.
Fixed the wavedrom diagrams and set the heading levels.
As per Ved, remove line 325 as it repeats line 322.
Remove repeasted line and add admonition formatting.
Adding Ved's fixes as per comments in GH.
Added text regarding CONTEXT bit in hstateen0.
Signed-off-by: Bill Traynor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the applicable adoc content from the Smstateen repository to the smstateen.adoc file and included in the Priv header. Set chapter anchor, titled to be consistent with other extension chapter titles in priv and set header levels appropriately.