Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Zam; define misaligned atomicity granule PMA #1206

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Remove Zam; define misaligned atomicity granule PMA #1206

merged 2 commits into from
Jan 30, 2024

Conversation

aswaterman
Copy link
Member

@aswaterman aswaterman commented Jan 29, 2024 •
edited
Loading

Resolves #1114

@ved-rivos
Copy link
Collaborator

reasons of address alignment, and the instruction will give rise to only one memory operation for the purposes of RVWMO--i.e., it will execute atomically.

Should also be same for the purposes of RVTSO.

@aswaterman
Copy link
Member Author

aswaterman commented Jan 30, 2024 •
edited
Loading

@ved-rivos Since RVTSO is specified in terms of RVWMO, that follows. In other similar cases, we've avoided mentioning RVTSO to avoid cluttering the text, and I'd like to stick to that discipline.

gfavor
gfavor approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@gfavor gfavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aswaterman aswaterman merged commit 080ef75 into main Jan 30, 2024
2 checks passed
@aswaterman aswaterman deleted the misaligned-atomics branch January 30, 2024 06:49
aswaterman added a commit that referenced this pull request Jan 30, 2024
@aswaterman
Add changelog entry for #1206
c33a55e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfavor gfavor gfavor approved these changes

@kasanovic kasanovic Awaiting requested review from kasanovic

Assignees
No one assigned
Labels
Privileged Architecture v1.13
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define misaligned atomicity granule PMA
3 participants
@aswaterman @ved-rivos @gfavor