Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contradictory req. for ndmresetpending #951

Conversation

JanMatCodasip
Copy link
Contributor

Definition of dmstatus.ndmresetpending bit says that this bit should be equal to 1 while dmcontrol.ndmreset is asserted, implying that dmstatus.ndmresetpending is readable even under ndmreset.

Therefore, this merge request updates the text that specifies which DM register accesses are defined under ndmreset.

The change has been discussed here: #944

Copy link
Collaborator

@pdonahue-ventana pdonahue-ventana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I think that we should hold off on merging this until we're dealing with all of the changes that come out of public review.

Conflicts:
	debug_module.tex
@rtwfroody rtwfroody force-pushed the fix-contradictory-ndmresetpending-requirements branch from bd154a5 to 74dbb5b Compare February 27, 2024 21:10
@rtwfroody
Copy link
Collaborator

The asciidoc merge caused conflicts. I rebased the branch onto it. @JanMatCodasip can you confirm that this is still the same change?

@rtwfroody rtwfroody changed the base branch from main to rc2 March 7, 2024 18:08
@pdonahue-ventana
Copy link
Collaborator

@JanMatCodasip: Can you confirm that this PR is still what you were proposing? If so, I think that we can merge this PR that came from the public review process.

@JanMatCodasip
Copy link
Contributor Author

@rtwfroody, @pdonahue-ventana I am sorry for my delayed reply.

Yes, the current change is all right and corresponds to the original proposal.

@rtwfroody rtwfroody merged commit a7c19ac into riscv:rc2 Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants