Better description of how etrigger matches. #1085
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtwfroody
reviewed
Nov 22, 2024
| causes are configured by writing the corresponding bit in {csr-tdata2}. | ||
| (E.g. to trap on an illegal instruction, the debugger sets bit 2 in | ||
| {csr-tdata2}.) | ||
| This trigger can match when a trap is taken due to an exception. |
There was a problem hiding this comment.
This feels like a very wish-washy statement.
How about:
This trigger matches when an exception is taken and the bit corresponding to the exception is set in tdata2.
Probably requires rewriting the paragraph below for it all to make sense.
There was a problem hiding this comment.
This feels like a very wish-washy statement.
I agree. I didn't like the phrasing but I was trying to match the existing itrigger description which was updated last year. I was trying to limit the scope of this change but maybe we should update itrigger, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous language talked about "When the trigger matches" but it never described matching. It said that it could fire on mcause codes but did that mean a CSR write instruction with a particular mcause value could make it fire? I think that this is better.
Fixes #1084.