-
Notifications
You must be signed in to change notification settings - Fork 40
chore: get instruction appendix ready for release #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. Will you also add the assembly field to the erb template or do you prefer me to do so in a separate PR?
@dhower-qc is it fine with you if I add a commit with a Assembly field being reliant on an environment variable? |
What would that look like? |
My idea was to add a couple lines to the erb template that prints the Assembly field if "ASSEMBLY=1". |
ahhh, I see. I thought you meant a variable that changes the string. I have no problem with ASSEMBLY=1 |
This does several things:
I'll also add a regression to check a "golden" output.