Skip to content

Add SimpleCov and test coverage reporting #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add SimpleCov and test coverage reporting #654

wants to merge 2 commits into from

Conversation

Shehrozkashif
Copy link
Collaborator

Closes #629

@Shehrozkashif
Copy link
Collaborator Author

@ThinkOpenly @dhower-qc @james-ball-qualcomm @AFOliveira
I have started working on #629 by reviewing this PR. Could you please guide me on whether I am on the right track?

@kbroch-rivosinc
Copy link
Collaborator

kbroch-rivosinc commented Apr 23, 2025 •
edited
Loading

@Shehrozkashif You'll want remove to coverage dir artifacts from your commit and put it in .gitignore file
https://github.com/simplecov-ruby/simplecov?tab=readme-ov-file#getting-started
See step 5.

UPDATE: We should discuss this but IMO we don't want artifacts checked into the repo.

@Shehrozkashif
Copy link
Collaborator Author

@kbroch-rivosinc
You're absolutely right — the coverage/ directory should not be part of the repository. Ill remove it from the commit and add it to .gitignore

Let me know if there's anything else you'd like me to adjust. I'm happy to discuss further

kbroch-rivosinc
kbroch-rivosinc reviewed Apr 24, 2025
View reviewed changes
kbroch-rivosinc
kbroch-rivosinc reviewed Apr 24, 2025
View reviewed changes
dhower-qc
dhower-qc requested changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@dhower-qc dhower-qc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely on the right track. Think you can get coverage of the regression tests?

@Shehrozkashif Shehrozkashif force-pushed the ruby_test branch 2 times, most recently from 2812852 to 2f3f30d Compare April 27, 2025 17:12
@Shehrozkashif Shehrozkashif requested a review from ThinkOpenly as a code owner May 3, 2025 18:19
@Shehrozkashif Shehrozkashif requested a review from dhower-qc May 5, 2025 20:18
dhower-qc
dhower-qc requested changes May 6, 2025
View reviewed changes
ext/docs-resources
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like to you need to run git submodule update, unless you actually meant to update that pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbroch-rivosinc kbroch-rivosinc kbroch-rivosinc left review comments

@AFOliveira AFOliveira AFOliveira left review comments

@dhower-qc dhower-qc dhower-qc requested changes

@ThinkOpenly ThinkOpenly Awaiting requested review from ThinkOpenly ThinkOpenly is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run code coverage tool on Ruby code
4 participants
@Shehrozkashif @kbroch-rivosinc @dhower-qc @AFOliveira