-
Notifications
You must be signed in to change notification settings - Fork 40
Add CSR YAML files for Smcntrpmf: mcyclecfg and minstretcfg #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add CSR YAML files for Smcntrpmf: mcyclecfg and minstretcfg #595
Conversation
@ThinkOpenly Thanks for the feedback! I’ve made the following updates:
|
@ThinkOpenly I'll update the PR by adding mcyclecfgh and minstretcfgh, using a table format for privilege modes, and ensuring consistency in the comments and formatting across the YAML files.Thanks for the suggestion, and sorry for the oversight! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you be adding mcyclecfgh
and minstretcfgh
? These are the 32-bit (high) versions of these registers, so very similar definitions.
Thank you for the detailed feedback, and apologies for the earlier confusion. I've now made the following updates:
Please let me know if anything still needs adjustment! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close.
The *INH fields should be definedBy
the extension they control so that they appear to not be implemented if that extension isn't present.
For example
definedBy: Smcntrpmf
fields:
SINH:
definedBy: S
VSINH:
definedBy: H
# ...
Implement CSR YAMLs :
MCYCLECFG
MINSTRETCFG
Closes Add Smcntrpmf registers #568