Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Olympia to add support for multiple load/store pipelines-LFX Mentorship Enhancement to Olympia: Ojus Chugh #202

Closed
wants to merge 1 commit into from

Conversation

ojuschugh1
Copy link

Pull Request Summary
This pull request introduces several key changes to the LSU class constructor to support multiple pipelines and improve the management of load/store instructions for the LFX mentorship Task. The updates include:

Support for Multiple Pipelines:

Added functionality to handle multiple pipelines (num_pipelines_).

Copy link
Collaborator

@klingaard klingaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to the LFX mentorship challenge!

This is very good work and on the correct path towards the goals we were trying to achieve for multiple LS pipelines.

For those that might look at this PR for inspiration, a couple of notes:

  1. The number of issue queues does is not necessarily tied to the number of pipelines. Dispatch (which sends the instructions to LS) will not know the number of issue queues and only sends instructions based on credits from probably 1 queue
  2. Each pipeline is being treated equally. One intent of multiple pipelines is to separate loads from stores, have "generic" pipelines, etc. This PR is a good start towards that goal

@klingaard
Copy link
Collaborator

Closing this PR. Thank you for challenge contribution.

@klingaard klingaard closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants