Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call setup_stf_linker for debug and profile builds #159

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Call setup_stf_linker for debug and profile builds #159

merged 1 commit into from
Mar 11, 2024

Conversation

danbone
Copy link
Contributor

@danbone danbone commented Mar 5, 2024

Fix for #158

@klingaard
Copy link
Collaborator

Hey @bdutro can you take a quick look at this PR? Is this the intended usage of the STF linker configs?

@klingaard klingaard self-requested a review March 11, 2024 17:03
@klingaard klingaard added the bug Something isn't working label Mar 11, 2024
bdutro
bdutro approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@bdutro bdutro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the correct way to do it.

@klingaard klingaard merged commit 9d9a345 into riscv-software-src:master Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdutro bdutro bdutro approved these changes

@klingaard klingaard klingaard approved these changes

Assignees

@danbone danbone

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danbone @klingaard @bdutro