riscv: sim.cc: Parse for other compatible strings if "riscv,plic0" is absent #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The kernel file and commit you pointed to say that thead and andes PLICs have different behavior than the first two. (plic_init vs plic_edge_init) |
endeneer
force-pushed
the
fdt-parse-plic-sifive
branch
3 times, most recently
from
98ebdb7 to
2dbbcaa
Compare
|
Thanks @scottj97 for pointing that out, I have amended my commit accordingly. :-) |
jerryz123
force-pushed
the
fdt-parse-plic-sifive
branch
from
2dbbcaa to
6ca19fb
Compare
jerryz123
approved these changes
Dec 11, 2023
"riscv,plic0" and "sifive,plic-1.0.0" in device tree's "compatible" string point to the same driver, as can be seen from drivers/irqchip/irq-sifive-plic.c in Linux kernel. torvalds/linux@5873ba5 The other two "compatible" strings below isn't included, because of their different plic behavior (plic_edge_init instead of plic_init as explained in the Linux commit). - "andestech,nceplic100" - "thead,c900-plic" Signed-off-by: Tan En De <[email protected]>
aswaterman
approved these changes
Dec 11, 2023
jerryz123
force-pushed
the
fdt-parse-plic-sifive
branch
from
6ca19fb to
87690a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three more compatible strings in device tree that point to the same driver,
as can be seen from drivers/irqchip/irq-sifive-plic.c in Linux kernel. torvalds/linux@5873ba5