Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest, with ch4 #18

Merged
merged 12 commits into from
Dec 14, 2023
Merged

Latest, with ch4 #18

merged 12 commits into from
Dec 14, 2023

Conversation

NicholasWoodIMG
Copy link
Collaborator

No description provided.

andrewdellow
andrewdellow reviewed Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@andrewdellow andrewdellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is HW RoT optional (should) ?

rsahita
rsahita requested changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@rsahita rsahita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some changes - and then can approve - Looks good!

NicholasWoodIMG and others added 4 commits December 13, 2023 10:54
rsahita
rsahita approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@rsahita rsahita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments remain, with those addressed, approved - thanks Nicholas!

@NicholasWoodIMG
Update from review comments.
6d30e51 
Signed-off-by: NicholasWoodIMG <[email protected]>
@NicholasWoodIMG
Update from review comments.
8a32c7c 
Signed-off-by: NicholasWoodIMG <[email protected]>
@NicholasWoodIMG
Updated from review.
b000373 
Signed-off-by: NicholasWoodIMG <[email protected]>
rsahita
rsahita approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@rsahita rsahita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve with comments resolved

@NicholasWoodIMG
Update from reviews.
cd55174 
Signed-off-by: NicholasWoodIMG <[email protected]>
@NicholasWoodIMG
Updated from review.
c733654 
Signed-off-by: NicholasWoodIMG <[email protected]>
@NicholasWoodIMG
Update chapter2.adoc
bfb431e 
Signed-off-by: NicholasWoodIMG <[email protected]>
@rsahita rsahita merged commit b690979 into main Dec 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewdellow andrewdellow andrewdellow left review comments

@lfiolhais lfiolhais lfiolhais left review comments

@ved-rivos ved-rivos ved-rivos approved these changes

@rsahita rsahita rsahita approved these changes

@elliops elliops Awaiting requested review from elliops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NicholasWoodIMG @lfiolhais @rsahita @andrewdellow @ved-rivos