target/riscv: DMI logging improvements #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iade30374331e9bde31a411b82056d47207cc39a8 Signed-off-by: Evgeniy Naydanov <[email protected]>
en-sc
force-pushed
the
en-sc/batch-logging
branch
from
9fcfe53
to
df5b531
Compare
|
Note to the reviewers -- this PR contains two commits.
|
en-sc
force-pushed
the
en-sc/batch-logging
branch
from
df5b531
to
dfd6e83
Compare
Fixes riscv-collab#1043 There were multiple issuese with DMI logging: 1. Address was assumed to be the same (riscv-collab#1043). 2. Reported IDLE count was not affected by a reset of the delays. 3. VLA were used. These issues are addressed in the commit. Change-Id: I82f45505e8a62dfdd7dcb418784975fe10180109 Signed-off-by: Evgeniy Naydanov <[email protected]>
en-sc
force-pushed
the
en-sc/batch-logging
branch
from
dfd6e83
to
250aa20
Compare
| if (debug_level < LOG_LVL_DEBUG) | ||
| return; | ||
|
|
||
| const unsigned int scan_bits = batch->fields->num_bits; |
There was a problem hiding this comment.
Pedantic detail:
You can use fields[0].num_bits instead of fields->num_bits to make it clearer that fields is pointing to an array of items, not just a single item.
Suggested change
| const unsigned int scan_bits = batch->fields->num_bits; | |
| assert(batch->used_scans > 0); | |
| const unsigned int scan_bits = batch->fields[0].num_bits; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1043
There were multiple issuese with DMI logging:
riscv_decode_dmi_scan()#1043).These issues are addressed in the commit.