Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spotify sending double instead of int for documented endpoints #208

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

KRTirtho
Copy link
Contributor

@KRTirtho KRTirtho commented Mar 1, 2024

Extending @hayribakici fix, I applied the same convertToInIfDoubleValue for all int and int? type properties across the library just to be future-proof 😅

Currently, it's happening for the following endpoints:

  • album/tracks,
  • artists, (fixed + releases)
  • artist, (fixed + releases)
  • artist/related-artists (fixed + releases)

@KRTirtho
Copy link
Contributor Author

KRTirtho commented Mar 1, 2024

Closes #207

@hayribakici
Copy link
Collaborator

oh man, I thought this wouldn't hunt us anymore 😅

Copy link
Owner

@rinukkusu rinukkusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this!
What are they cooking in the public api department at Spotify? 🤔

@rinukkusu rinukkusu merged commit c42c8ab into rinukkusu:master Mar 1, 2024
2 checks passed
@KRTirtho
Copy link
Contributor Author

KRTirtho commented Mar 3, 2024

Proprietary API. Think about the actual paid customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants