Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand shortened spotify url #200

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

hayribakici
Copy link
Collaborator

This PR fixes #154 and adds a new method spotifyApi.expandLink(shortenedUrl) to expand shortened links.

In order that to happen the underlying http library has been updated to version 1.2.0.

@hayribakici
Copy link
Collaborator Author

@rinukkusu currently library users have to have a spotifyApi instance to access this new function. However, it would also work if we make this method static. I am currently on the fence with this one, what do you think?

@rinukkusu
Copy link
Owner

Let's make it static then! Sounds like a good idea.

@hayribakici
Copy link
Collaborator Author

oh, I was mistaken. Nevermind. It's not possible to make it static, since we are using the requestWrapper() method.

Copy link
Owner

@rinukkusu rinukkusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sad! 😞 Let's pull it in then as it is!

@rinukkusu rinukkusu merged commit 21d37f9 into rinukkusu:master Feb 20, 2024
2 checks passed
@hayribakici hayribakici deleted the #154_HEAD branch February 20, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotify short link support to get track - missing
2 participants