WAT-4235: Align plugin-selenium-driver with WebDriver protocol & improve e2e-test-app

.c8.json

@@ -0,0 +1,10 @@
+{
+  "reporter": ["html"],
+  "reports-dir": "./c8-cov",
+  "all": true,
+  "include": [
+    "packages/plugin-selenium-driver/*/plugin/index.*",
+    "packages/web-application/*/web-client.*",
+    "packages/web-application/*/web-application.*"
+  ]
+}

.gitignore

@@ -1,4 +1,5 @@
 packages/**/dist
+packages/**/chrome-cache
 packages/**/node_modules
 
 core/**/dist

core/api/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/async-assert/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/async-breakpoints/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/child-process/src/fork.ts

@@ -21,7 +21,7 @@ const PREFERRED_DEBUG_PORTS: Array<number> = [
 const IS_WIN = process.platform === 'win32';
 const EMPTY_PARAMETERS = [];
 const REQUIRE_TS_NODE = ['-r', 'ts-node/register'];
-const Module = require("module").Module;
+const Module = require('module').Module;
 
 const DEFAULT_FORK_OPTIONS: IChildProcessForkOptions = {
     debug: false,

core/child-process/src/index.ts

@@ -1,3 +1,4 @@
 export {spawn} from './spawn';
+export {spawnWithPipes} from './spawn-with-pipes';
 export {fork} from './fork';
 export {isChildProcess} from './utils';

core/child-process/src/spawn-with-pipes.ts

@@ -0,0 +1,18 @@
+import * as childProcess from 'child_process';
+import * as process from 'process';
+
+export function spawnWithPipes(
+    command: string,
+    args: Array<string> = [],
+): childProcess.ChildProcess {
+    const child = childProcess.spawn(command, args, {
+        stdio: ['pipe', 'pipe', 'pipe'], // Use pipes for proper control
+        cwd: process.cwd(),
+        detached: false, // Run attached to prevent orphan processes
+    });
+
+    // Ensure child does not keep the event loop active
+    child.unref();
+
+    return child;
+}

core/child-process/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/cli-config/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/cli/src/commands/runCommand.ts

@@ -59,7 +59,6 @@ class RunCommand implements ICLICommand {
     }
 
     async execute() {
-
         const testWorker = new TestWorker(this.transport, {
             waitForRelease: false,
             localWorker: this.config.workerLimit === 'local',

core/cli/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/dependencies-builder/src/index.ts

@@ -10,6 +10,7 @@ import {
     DependencyFileReader,
 } from '@testring/types';
 import {resolveAbsolutePath} from './absolute-path-resolver';
+import * as path from 'node:path';
 
 function getDependencies(absolutePath: string, content: string): Array<string> {
     const requests: Array<string> = [];
@@ -21,14 +22,14 @@ function getDependencies(absolutePath: string, content: string): Array<string> {
     });
 
     traverse(sourceAST, {
-        CallExpression(path: NodePath<CallExpression>) {
-            const callee = path.get('callee') as NodePath<Identifier>;
+        CallExpression(nodePath: NodePath<CallExpression>) {
+            const callee = nodePath.get('callee') as NodePath<Identifier>;
 
             if (callee.node.name !== 'require') {
                 return;
             }
 
-            const args = path.get('arguments');
+            const args = nodePath.get('arguments');
             const firstArgument = args[0];
             const dependencyPath: NodePath<string> = firstArgument.get(
                 'value',
@@ -42,24 +43,24 @@ function getDependencies(absolutePath: string, content: string): Array<string> {
 }
 
 function createTreeNode(
-    path: string,
+    nodePath: string,
     content: string,
     nodes: IDependencyDictionary<IDependencyTreeNode> | null,
 ): IDependencyTreeNode {
     return {
         content,
-        path,
+        path: nodePath,
         nodes,
     };
 }
 
 function createDictionaryNode(
-    path: string,
+    nodePath: string,
     content: string,
 ): IDependencyDictionaryNode {
     return {
         content,
-        path,
+        path: nodePath,
     };
 }
 
@@ -103,7 +104,7 @@ async function buildNodes(
             dependencyAbsolutePath.includes('node_modules') ||
             // Fix for local e2e tests running (lerna makes symlink and resolver eats it as path for real file)
             // require 'node_modules/testring' = require 'packages/testring/dist'
-            dependencyAbsolutePath.includes('testring/dist')
+            dependencyAbsolutePath.includes(path.join('testring', 'dist'))
         ) {
             continue;
         }

core/dependencies-builder/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/fs-reader/src/file-locator.ts

@@ -2,11 +2,11 @@ import * as fg from 'fast-glob';
 import * as process from 'node:process';
 
 export async function locateFiles(searchpath: string): Promise<string[]> {
-    if(!searchpath) {
+    if (!searchpath) {
         return [];
     }
     if (process.platform === 'win32') {
         searchpath = fg.convertPathToPattern(searchpath);
     }
     return await fg(searchpath, {});
-}
+}

core/fs-reader/src/file-resolver.ts

@@ -37,7 +37,7 @@ export async function resolveFiles(files: Array<string>): Promise<IFile[]> {
 
     // Limit concurrent file reads
     const readFilePromises = files.map((file) =>
-        limit(() => readFile(file).catch(() => null))
+        limit(() => readFile(file).catch(() => null)),
     );
 
     const filesContent = await Promise.all(readFilePromises);
@@ -49,4 +49,3 @@ export async function resolveFiles(files: Array<string>): Promise<IFile[]> {
 
     return compacted;
 }
-

core/fs-reader/test/performance.spec.ts

@@ -8,7 +8,9 @@ import {FSReader} from '../src/fs-reader';
 import * as process from 'node:process';
 import * as fs from 'node:fs';
 
-const runPerformanceTests = process.env.PERFORMANCE_TESTS === 'true' || process.argv.includes('--performance');
+const runPerformanceTests =
+    process.env.PERFORMANCE_TESTS === 'true' ||
+    process.argv.includes('--performance');
 const glob = path.resolve(__dirname, './fixtures/testfiles/**/**/*.test.js');
 
 const writeTestFiles = async (count: number) => {
@@ -28,11 +30,10 @@ const removeTestFiles = async () => {
     const dir = path.resolve(__dirname, './fixtures/testfiles/performance');
 
     if (fs.existsSync(dir)) {
-        await fs.promises.rm(dir, { recursive: true, force: true });
+        await fs.promises.rm(dir, {recursive: true, force: true});
     }
 };
 
-
 describe('Performance', function () {
     this.timeout(120000);
     if (!runPerformanceTests) {
@@ -41,7 +42,6 @@ describe('Performance', function () {
         });
     } else {
         describe('FSReader', () => {
-
             before(async () => {
                 await writeTestFiles(15000);
             });

core/fs-reader/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/fs-store/src/fs-store-client.ts

@@ -68,9 +68,8 @@ export class FSStoreClient {
                         delete this.reqHash[requestId];
                     } else {
                         this.reqHash[requestId].fullPath = fullPath;
-                        this.reqHash[requestId].meta.fileName = path.basename(
-                            fullPath,
-                        );
+                        this.reqHash[requestId].meta.fileName =
+                            path.basename(fullPath);
                     }
                 }
 

core/fs-store/src/fs-store-server.ts

@@ -57,10 +57,8 @@ export class FSStoreServer extends PluggableModule {
     private unHookCleanWorkerTransport: (() => void) | null = null;
     private defaultFsPermisionPool: LockPool;
 
-    private files: Record<
-        string,
-        [FilePermissionResolver, cleanUpCBRecord]
-    > = {};
+    private files: Record<string, [FilePermissionResolver, cleanUpCBRecord]> =
+        {};
     private inWorkRequests: Record<
         string,
         Record<string, [fsReqType, string]>

core/fs-store/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/logger/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/pluggable-module/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/plugin-api/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/sandbox/test/sandbox.spec.ts

@@ -80,16 +80,8 @@ describe('Sandbox', () => {
         it('should correctly pass "instanceof" check for all primitives', async () => {
             const source = await fixturesFileReader('primitives.js');
             const sandbox = new Sandbox(source, 'primitives.js', {});
-            const {
-                array,
-                map,
-                set,
-                weakMap,
-                weakSet,
-                promise,
-                buffer,
-                error,
-            } = sandbox.execute();
+            const {array, map, set, weakMap, weakSet, promise, buffer, error} =
+                sandbox.execute();
 
             chai.expect(array instanceof Array).to.be.equal(true);
             chai.expect(map instanceof Map).to.be.equal(true);

core/sandbox/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/test-run-controller/src/test-run-controller.ts

@@ -23,7 +23,8 @@ const delay = (milliseconds: number) =>
 
 export class TestRunController
     extends PluggableModule
-    implements ITestRunController {
+    implements ITestRunController
+{
     private workers: Array<ITestWorkerInstance> = [];
 
     private errors: Array<Error> = [];
@@ -189,13 +190,8 @@ export class TestRunController
     private getQueueItemWithRunData(queueItem): IQueuedTest {
         let screenshotsEnabled = false;
         const isRetryRun = queueItem.retryCount > 0;
-        const {
-            debug,
-            httpThrottle,
-            logLevel,
-            devtool,
-            screenshotPath,
-        } = this.config;
+        const {debug, httpThrottle, logLevel, devtool, screenshotPath} =
+            this.config;
 
         if (this.config.screenshots === 'enable') {
             screenshotsEnabled = true;

core/test-run-controller/tsconfig.json

@@ -10,7 +10,7 @@
     "noEmitOnError": true,
     "declaration": false,
     "outDir": "dist",
-    "sourceMap": false,
+    "sourceMap": true,
     "lib": [
       "es5",
       "es2015",

core/test-worker/src/test-worker-instance.ts

@@ -260,11 +260,12 @@ export class TestWorkerInstance implements ITestWorkerInstance {
                 completeHandler,
             );
         } else {
-            removeListener = this.transport.onceFrom<ITestExecutionCompleteMessage>(
-                this.getWorkerID(),
-                TestWorkerAction.executionComplete,
-                completeHandler,
-            );
+            removeListener =
+                this.transport.onceFrom<ITestExecutionCompleteMessage>(
+                    this.getWorkerID(),
+                    TestWorkerAction.executionComplete,
+                    completeHandler,
+                );
         }
 
         this.successTestExecution = () => {