Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Partitioned/CHIPS cookies #493

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

NoahTheDuke
Copy link
Contributor

@NoahTheDuke NoahTheDuke commented Jan 22, 2024

Adds simple support for Partitioned cookies. Does no validation (requiring :secure). I briefly considered it, but that felt like a step too far.

Closes #492

@weavejester
Copy link
Member

Can you remove the atom and var privacy changes? A PR should be focused on fixing one bug or implementing one feature.

@NoahTheDuke
Copy link
Contributor Author

Force-pushed the changes, so it's purely the addition of :partitioned.

@weavejester
Copy link
Member

Thanks for the update!

@weavejester weavejester merged commit ca7b259 into ring-clojure:master Jan 24, 2024
1 check passed
@NoahTheDuke NoahTheDuke deleted the nb/partitioned-cookies branch January 24, 2024 15:39
@NoahTheDuke
Copy link
Contributor Author

Hey James, any chance this will be released soon?

@weavejester
Copy link
Member

Coincidentally, I was just looking into what would be needed to cut a 1.12 release. It should be released within a week.

@NoahTheDuke
Copy link
Contributor Author

Thanks homie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Partitioned cookies (CHIPS)
2 participants