Add .xlsx extension to the mimetypes map #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weavejester Would you have some time to check this one? It is just one line |
|
Sorry for the delay. It looks like you've typoed the minetype. You've put in the file path to the namespace, instead of the mimetype you linked to. |
|
@weavejester facepalm sorry about that, fixed now. Thanks for taking the time! |
|
Merged. Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this for some tests I'm writing using https://github.com/xeqi/peridot, which in turn uses this. But still would be nice to have if you're serving them with a web server or whatever I think.
I checked the MIME type and it is in here: https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types and it's what firefox sends when uploading XLSX too.
Thanks for your time!