Add toggle pagination support to games view #376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the type contribution you are making:
Description
Why is this change necessary?
This PR is to add pagination support to the games view when toggling the page control buttons at the bottom of the screen. Right now, a user can tap these buttons and will stay on the current page while the icons toggle between selection.
Why did you decide on this solution?
This PR is also a continuation of Update page control on games view #101, which seems to have been stagnant for a few years. I've implemented the changes needed based on the comments posted on that PR.
Testing
List all iOS versions and devices you've tested this change on.
Example Configurations:
I'd like to test running it on an iPhone device, but I've been getting this error.
Does anyone have any idea on how to get around this? Any help is much appreciated 🙏.
Checklist
General (All PRs)
Experimental Feature-specific
ExperimentalFeatures
struct annotated with@Feature
@Option
's to persist all feature-related dataExperimentalFeatures.shared.[feature].isEnabled
runtime check