Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Ashton Malone #281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

TTVMG2021
Copy link

@TTVMG2021 TTVMG2021 commented Jan 27, 2024

Pokemon

Mark the type contribution you are making:

  • Experimental feature (new functionality that can be selectively enabled/disabled)
  • Bug fix (non-breaking change which fixes an issue)

Description

Summary of your changes, including:

  • Why is this change necessary?
  • Why did you decide on this solution?

Testing

List all iOS versions and devices you've tested this change on.

Example Configurations:

  • iPhone 14, iOS 16.3.1
  • iPhone X, iOS 15.7.4

Checklist

General (All PRs)

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I've tested my changes with different device + OS version configurations

Experimental Feature-specific

  • Added property to ExperimentalFeatures struct annotated with @Feature
  • Uses @Option's to persist all feature-related data
  • Locked all behavior changes behind ExperimentalFeatures.shared.[feature].isEnabled runtime check
  • Isolates changes to separate files as much as possible (e.g. via Swift extensions)

@TTVMG2021
Copy link
Author

Please I want to play pokemon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant