Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing <algorithm> header (gcc14) #218

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

SGSSGene
Copy link
Contributor

@SGSSGene SGSSGene commented Jun 6, 2024

gcc14 is complaining about unknown "std::find_if" function. (gcc13 works fine)

Description

Adds the header to bitinputarchive.cpp.

Motivation and Context

project isn't compiling with gcc14. It complains about std::find_if not known function.

How Has This Been Tested?

I simply compiled it with gcc14.1.1, no further tests.

Types of changes

Nothing changed.

Checklist:

  • My code follows the code style of this project. (style is unclear to me)
  • My change requires a change to the documentation. (not required)
  • I have updated the documentation accordingly. (not required)

gcc14 is complaining about unknown "std::find_if" function. (gcc13 works
fine)
@rikyoz rikyoz self-requested a review June 6, 2024 16:19
@rikyoz
Copy link
Owner

rikyoz commented Jun 6, 2024

Hi!
Thanks for the PR!
Yes, on the develop branch I added the missing include some time ago, but didn't backport the change to the `master' branch as no compiler was complaining at the time; then GCC 14 happened 😅.

@rikyoz rikyoz merged commit 24ad26f into rikyoz:master Jun 6, 2024
168 checks passed
@SGSSGene SGSSGene deleted the fix/gcc14_missing_header branch June 6, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants