chore: update github actions knope version to 0.7.2 #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jselig-rigetti
changed the title
|
Knope is on v0.18.1; any reason for keeping this so far behind? |
@BatmanAoD After heeding the Test before updating, breaking changes likely comment, I tried a The goal for this PR is just to fix the current broken release, but you have a good point - I added a comment to a mostly related issue you opened #507 (comment) |
|
@jselig-rigetti Bleargh... we're using Knope 0.16 in other repos, and the behavior has changed a fair bit since 0.7. You're right, though, that it can be part of #507. |
BatmanAoD
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently #519 failed because of knope-dev/action#10
This fixes that by using the compatible https://github.com/knope-dev/knope/releases/tag/v0.7.2 tag