Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary identity operation from exponential_map() #373

Closed
wants to merge 4 commits into from
Closed

Removing unnecessary identity operation from exponential_map() #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2da92c3
removing unnecessary identity operation from exponential_map()
markf94 Mar 30, 2018
aec87e9
fixed test_exponentiate_identity tests appropriately
markf94 Mar 30, 2018
34124a8
Merge branch 'master' into identity_ops
mpharrigan Mar 31, 2018
e8f5b10
Merge branch 'master' into identity_ops
ecpeterson Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions pyquil/paulis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,12 +846,7 @@ def exponential_map(term):

def exp_wrap(param):
prog = Program()
if is_identity(term):
prog.inst(X(0))
prog.inst(PHASE(-param * coeff, 0))
prog.inst(X(0))
prog.inst(PHASE(-param * coeff, 0))
elif is_zero(term):
if is_identity(term) or is_zero(term):
pass
else:
prog += _exponentiate_general_case(term, param)
Expand Down
4 changes: 2 additions & 2 deletions pyquil/tests/test_paulis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,13 +382,13 @@ def test_exponentiate_identity():
generator = PauliTerm("I", 1, 1.0)
para_prog = exponential_map(generator)
prog = para_prog(1)
result_prog = Program().inst([X(0), PHASE(-1.0, 0), X(0), PHASE(-1.0, 0)])
result_prog = Program()
assert prog == result_prog

generator = PauliTerm("I", 10, 0.08)
para_prog = exponential_map(generator)
prog = para_prog(1)
result_prog = Program().inst([X(0), PHASE(-0.08, 0), X(0), PHASE(-0.08, 0)])
result_prog = Program()
assert prog == result_prog


Expand Down