-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes Notebooks a part of testing (Issue 74) #123
Conversation
… the notebook (currently) has errors
…empty string as per Peter's suggestion.
Thanks to @karalekas fix the code should work locally and remotely. |
This is weird. The tests pass on gitlab but the semaphoreci build fails. @karalekas thoughts? |
@joshcombes Two things. (1) Currently the GitLab tests skip the ones that use qvm/quilc (which is a lot of them, so I need to fix that), so there is certainly a chance the GL and Semaphore outputs could be different. (2) Are you able to see the output of the tests on Semaphore? The failure is due to SCS, which is finicky (see #61) and therefore we decided to disable unit tests involving SCS. Take a look at the associated PR to see how we check for the |
@karalekas the Semaphore thing is hard to decode. In this case it was an easy fix using an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we should either include the process tomography test or make an issue if the notebook isn't working.
This PR adds notebooks to our testing procedure using
nbval
. See issue #74 .The PR includes:
conftest.py
to enable skipping slow testsrequirements.txt
ofnbval
test_example_notebooks.py
(notebooks which are longer than 30 seconds are skipped). The test passes if all the cells in a notebook can execute.